feat!: migrate adapter to Molecule API#11
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .: | ||
| dependencies: | ||
| '@sigrea/core': | ||
| specifier: ^0.3.1 | ||
| version: 0.3.1 | ||
| devDependencies: | ||
| '@biomejs/biome': | ||
| specifier: 1.9.4 | ||
| version: 1.9.4 | ||
| '@sigrea/core': | ||
| specifier: ^0.3.1 | ||
| version: 0.3.1 |
There was a problem hiding this comment.
The lockfile still lists @sigrea/core as a devDependency (lines 9-16) but its resolution block was removed (rg "@sigrea/core@" pnpm-lock.yaml now returns no matches), so pnpm install --frozen-lockfile will fail because the lock cannot resolve that package and will force a re-resolution. Reintroduce the package entry so installs remain reproducible.
Useful? React with 👍 / 👎.
# Conflicts: # package.json
# Conflicts: # package.json
1 participant
Purpose
Migrate the React adapter from the legacy
logicAPI to themoleculeAPI in@sigrea/core.Summary
useLogictouseMolculeand replacedmountLogic/cleanupLogicwith direct molecule creation anddisposeMolecule.@sigrea/coreto^0.4.0.Breaking change / Migration
useLogic(...)->useMolcule(...)Verification
pnpm test(CI)pnpm typecheck(CI)pnpm build(CI)pnpm format(CI)